Skip to content

Conversation

@agisboye
Copy link

In order to fix #319 in SQLite.swift submodule.

agisboye added 2 commits January 12, 2016 15:22
In order to fix #319 in SQLite.swift.
Turns out that this project was building SQLite.swift and not
SQLiteCipher.swift.

It now has two schemes, one for iOS and one for Mac. Both build the
same SQLiteCipher.framework.
@agisboye agisboye mentioned this pull request Jan 12, 2016
@agisboye agisboye changed the title Update SQLite.swift subproject. Update SQLite.swift subproject & resolve build issues Jan 12, 2016
@agisboye agisboye changed the title Update SQLite.swift subproject & resolve build issues Resolve build issues Jan 12, 2016
@gblotter
Copy link

@stephencelis any update on this??

@@ -1,6 +1,3 @@
[submodule "Vendor/sqlcipher"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask why this was removed as a submodule? (just want to learn...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carthage wasn't building the amalgamation target properly, if I recall correctly. The easiest solution was to remove sqlcipher as a submodule and manually add some files that Xcode complained were missing. Now with Xcode 7.3, though, it doesn't build at all. I haven't been able to get it working.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've experienced the same thing, regardless of whether or not I use your way in this PR or use sqlcipher as a submodule. Still working on it. Thanks for the response.

@stephencelis
Copy link
Owner

This was completely off my radar. Thanks for your work on this so far @agisboye!

@agisboye
Copy link
Author

It'd be great if we could get it working again. What I did back in January was add build schemes and make them shared (so as to expose them to Carthage). I also added sqlcipher manually because Carthage (via xcodebuild) was complaining about a missing sqlite.c file. With the release of Xcode 7.3, my fork is no longer working, and I have yet to figure out how to resolve the build issues.

@gblotter
Copy link

See PR #11 - I believe I figured out how to make it compile

@lferro9000
Copy link

Hi Stephen,

When is possibe to have this and #11 merged, so that building with cocoapods / carthage is fully functional?

Cheers,
LF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

carthage build failed

4 participants