Add note about enabling modules in Xcode project #926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuiAAPeres
approved these changes
May 10, 2019
|
I would prefer that we make the change that Ankit recommends here https://bugs.swift.org/browse/SR-8629 Edit: The change recommended in the link is: "the generated project starts working as expected if you rename |
Contributor
Author
|
@danramteke Excellent, that is of course a much better solution if possible. |
Collaborator
|
@danramteke can you provide PR for this fix? |
Contributor
Author
|
@ypopovych Here is a PR – just an updated version of what @danramteke provided here |
Contributor
Author
|
Confirmed that it works by just doing what I did here but instead pointing SwiftPM to my branch. |
Collaborator
|
merged PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #925 – not an SQLite.swift issue, but an SwiftPM one, but worthy of a note here imo.