Scalar functions should throw errors #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1. |
Collaborator
|
@javanut13: I think this is a great change. Would you mind merging master manually so the PR can be merged? |
Collaborator
|
Sorry for the extra work @javanut13, but I had to revert a commit I made recently because it broke concurrent access for single connections (which I think is pretty important). Would you mind merging again? |
# Conflicts: # SQLiteTests/ConnectionPoolTests.swift
Contributor
Author
|
Merged 👍 |
Collaborator
|
Thanks! I'd love to see this merged @stephencelis if you get a chance. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to use the scalar functions in my app but don't want the risk of crashing due to some unexpected state of the database. The rest of the database queries throw exceptions to be handled by the application, I don't see any reason why this shouldn't apply to scalar functions (if there is and I've missed something really obvious then I'd like to hear it).