Adds watchOS support #381
Closed
Adds watchOS support #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Does this need to be made against master now that that Xcode 7.3 branch was merged in? |
Owner
|
Ah, yep, that'll make the merge easier. Would be nice to get this into the release! @acrookston any chance you can open another PR against |
Collaborator
Author
|
Yeah just a minute Andrew Crookston (Spelling mistakes courtesy of writing on my phone)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the new Xcode 7.3 fix on cocoapods-xcode-7-3.
Regarding tests: the existing ones pass, but it seems like there is no test suite for watch os apps. If somebody knows how to add them, I'd be happy to do it, but I just can't find that option.
However I've successfully integrated this version in my watch app which used an older version of SQLite.swift.
Let me know if there's anything else missing, I'd be happy to amend.