Skip to content

feat!: refactor API and add C API to math/base/special/cexp #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2023
Merged

feat!: refactor API and add C API to math/base/special/cexp #972

merged 4 commits into from
Apr 13, 2023

Conversation

steff456
Copy link
Contributor

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

  • Removes out keyword
  • Adds support for Complex128 dtype
  • Adds C implementation
  • Adds native addon with benchmark, tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

steff456 added 2 commits March 14, 2023 16:15
@steff456
remove: remove out keyword and add support for Complex128 data type i…
01c52ab 
…n cexp

BREAKING CHANGE: out keyword no longer supported, now downstream
libraries need to create a complex dtype to use this API
@steff456
feat: add C implementation and native addon to cexp
8661f92
@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 14, 2023
@steff456 steff456 requested review from Planeshifter and kgryte March 14, 2023 21:49
@steff456 steff456 self-assigned this Mar 14, 2023
kgryte
kgryte requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part, this PR is looking good. Need to resolve some comments regarding examples and test descriptions.

kgryte
kgryte approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte changed the title feat: add cexp addon feat!: refactor API and add C API to math/base/special/cexp Apr 13, 2023
@kgryte kgryte merged commit 5318182 into develop Apr 13, 2023
@kgryte kgryte deleted the cexp-addon branch April 13, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Assignees

@steff456 steff456

Labels
Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steff456 @kgryte