feat: add blas/ext/base/gjoin
#8742
Open
+1,385
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Dec 4, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 4, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 4, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 4, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 4, 2025
Comment on lines
+64
to
+69
| view = []; | ||
| ix = offsetX; | ||
| for ( i = 0; i < N; i++ ) { | ||
| view.push( get( xbuf, ix ) ); | ||
| ix += strideX; | ||
| } |
Member
There was a problem hiding this comment.
This is only something we want to do as a last resort, and I am not convinced that we should be making a data copy regardless.
kgryte
reviewed
Dec 4, 2025
| * var str = gjoin( x.length, ',', x, 1 ); | ||
| * // returns '1,2,3,4' | ||
| */ | ||
| ( N: number, separator: unknown, x: InputArray, strideX: number ): string; |
Member
There was a problem hiding this comment.
Why does the separator have an "unknown" type? Why are we not following array/base/join and typing this as string?
kgryte
reviewed
Dec 4, 2025
| * Returns a string created by joining strided array elements using a specified separator. | ||
| * | ||
| * @param {PositiveInteger} N - number of indexed elements | ||
| * @param {*} separator - separator |
kgryte
reviewed
Dec 4, 2025
| * Returns a string created by joining strided array elements using a specified separator and alternative indexing semantics. | ||
| * | ||
| * @param {PositiveInteger} N - number of indexed elements | ||
| * @param {*} separator - separator |
kgryte
reviewed
Dec 4, 2025
| } | ||
|
|
||
| // Create a view of the strided elements | ||
| view = []; |
Member
There was a problem hiding this comment.
Same concern as in the accessors implementation. My sense is that
- if
strideX == 1 && offsetX == 0 && N == x.length, then calljoin( x, separator ) - otherwise, perform manual concatenation (i.e., effectively copy the manual loop implementation from
array/base/joinand tweak to support strides)
Member
There was a problem hiding this comment.
And realistically speaking, what we could do is effectively move the implementation from array/base/join to this package and then have array/base/join be a thin wrapper over this package. E.g.,
var strided = require( '@stdlib/blas/ext/base/gjoin' ).ndarray;
function join( x, separator ) {
return strided( x.length, separator, x, 1, 0 );
}
kgryte
reviewed
Dec 4, 2025
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns an empty string if provided `N` parameter is less than or equal to zero', function test( t ) { |
Member
There was a problem hiding this comment.
Suggested change
| tape( 'the function returns an empty string if provided `N` parameter is less than or equal to zero', function test( t ) { | |
| tape( 'the function returns an empty string if provided an `N` parameter is less than or equal to zero', function test( t ) { |
kgryte
reviewed
Dec 4, 2025
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns an empty string if provided `N` parameter is less than or equal to zero (accessors)', function test( t ) { |
Member
There was a problem hiding this comment.
Suggested change
| tape( 'the function returns an empty string if provided `N` parameter is less than or equal to zero (accessors)', function test( t ) { | |
| tape( 'the function returns an empty string if provided an `N` parameter is less than or equal to zero (accessors)', function test( t ) { |
kgryte
reviewed
Dec 4, 2025
| actual = gjoin( x.length, ' - ', x, 1 ); | ||
| t.strictEqual( actual, '1 - 2 - 3', 'returns expected value' ); | ||
|
|
||
| actual = gjoin( x.length, 0, x, 1 ); |
Member
There was a problem hiding this comment.
I am not sure how worthwhile it is to support non-string types (at least explicitly/formally).
kgryte
reviewed
Dec 4, 2025
| actual = gjoin( x.length, ' - ', x, 1, 0 ); | ||
| t.strictEqual( actual, '1 - 2 - 3', 'returns expected value' ); | ||
|
|
||
| actual = gjoin( x.length, 0, x, 1, 0 ); |
kgryte
approved these changes
Dec 4, 2025
kgryte
requested changes
Dec 4, 2025
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Left an initial review. Main concern is avoiding unnecessary copies. We should only call array/base/join if certain conditions are met.
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#123.
Description
This pull request:
blas/ext/base/gjoinRelated Issues
This pull request has the following related issues:
blas/ext/base/joinmetr-issue-tracker#123Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Utilized AI to the fullest. Code generation, documentation, tests, benchmarks etc.
@stdlib-js/reviewers