feat: add ndarray/find-last
#8724
Draft
+3,513
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
headlessNode
commented
Dec 2, 2025
Comment on lines
+132
to
+154
| ```javascript | ||
| var array = require( '@stdlib/ndarray/array' ); | ||
| var ndarray2array = require( '@stdlib/ndarray/to-array' ); | ||
|
|
||
| function isEven( value ) { | ||
| return value % 2.0 === 0.0; | ||
| } | ||
|
|
||
| // Create an input ndarray: | ||
| var x = array( [ [ [ 1.0, 3.0 ], [ 5.0, 7.0 ] ], [ [ 9.0, 11.0 ], [ 13.0, 15.0 ] ] ] ); | ||
| // returns <ndarray> | ||
|
|
||
| var opts = { | ||
| 'sentinelValue': -999 | ||
| }; | ||
|
|
||
| // Perform reduction: | ||
| var out = findLast( x, opts, isEven ); | ||
| // returns <ndarray> | ||
|
|
||
| var v = out.get(); | ||
| // returns -999 | ||
| ``` |
Member
Author
There was a problem hiding this comment.
@kgryte I think there may be a bug in ndarray/find when passing a custom sentinelValue in the options object. I'm not sure how the CI for ndarray/find passed and it's missing tests.
I checked debugging ndarray/find by modifying the example in the examples/index.js, same thing. Could you confirm if there is indeed a bug in ndarray/find? I'll then open a PR for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#122.
Description
This pull request:
ndarray/find-lastRelated Issues
This pull request has the following related issues:
ndarray/find-lastmetr-issue-tracker#122Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers