Skip to content

chore: fix EditorConfig lint errors (issue #7439) #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2025

Conversation

dhernandeez13
Copy link
Contributor

Resolves #7439

Description

What is the purpose of this pull request?

This pull request:

  • Fixes an EditorConfig lint error caused by using tab characters instead of spaces in lib/node_modules/@stdlib/os/byte-order/manifest.json.
  • Converts indentation from tabs to spaces to comply with the EditorConfig style rules used in the repository.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

To confirm the fix locally, a manual script was used to ensure no tab characters remain in the file.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

dhernandeez13 and others added 3 commits June 22, 2025 03:00
This PR fixes the JavaScript linting error related to redeclaration of `TransformStream` in `lib/node_modules/@stdlib/bench/harness/lib/main.js`.

The local variable `TransformStream` was renamed to `StdlibTransformStream` to avoid redeclaration lint failures.

JSDoc comments were left unchanged to keep accurate type information.

Related Issues:
resolves stdlib-js#7440
Signed-off-by: Athan <kgryte@gmail.com>
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Jun 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 22, 2025

Coverage Report

Package Statements Branches Functions Lines
bench/harness $\color{green}513/513$
$\color{green}+100.00\%$
$\color{green}60/60$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}513/513$
$\color{green}+100.00\%$
os/byte-order $\color{green}94/94$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}94/94$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! manifest.json should have two-space indentation, so I made that change.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 22, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: fix EditorConfig lint errors (issue #7439)

PR-URL: https://github.com/stdlib-js/stdlib/pull/7450
Closes: https://github.com/stdlib-js/stdlib/issues/7439

Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: dhg0003 <danielpsnher@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 22, 2025
@Planeshifter Planeshifter merged commit de5c162 into stdlib-js:develop Jun 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants