Skip to content

build: add workflow to post comment on PRs accidentally closing tracking issues #6102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

build: add workflow to post comment on PRs accidentally closing tracking issues #6102

merged 2 commits into from
Apr 9, 2025

Conversation

Planeshifter
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • Adds a new workflow running script every 12 hours to check recent PRs for auto-closing language that references tracking issues
  • Prevents accidental closure of tracking issues by notifying contributors when they use "Resolves/Closes/Fixes" instead of "Progresses"

The script includes idempotency checks to avoid duplicate comments on the same PR.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter
build: add script and workflow to check for accidentally closed track…
7ac1308 
…ing issues in PRs

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: passed
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter requested a review from kgryte March 16, 2025 20:34
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 16, 2025
@Planeshifter Planeshifter mentioned this pull request Mar 16, 2025
Closed
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
kgryte
kgryte reviewed Apr 1, 2025
View reviewed changes
@kgryte kgryte added CI Issue or pull request specific to continuous integration environments. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 1, 2025
@Planeshifter
build: address PR feedback
cf02567 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: passed
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 5, 2025
@Planeshifter Planeshifter requested a review from kgryte April 5, 2025 18:46
kgryte
kgryte approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Tools Issue or pull request related to project tooling. and removed Needs Review A pull request which needs code review. labels Apr 9, 2025
@kgryte kgryte merged commit 3e872ed into develop Apr 9, 2025
45 checks passed
@kgryte kgryte deleted the philipp/comment-on-accidentally-closed-tracking-issues branch April 9, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
CI Issue or pull request specific to continuous integration environments. Tools Issue or pull request related to project tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add workflow to post comment on PRs accidentally closing tracking issues
3 participants
@Planeshifter @kgryte @stdlib-bot