Skip to content

feat: add C implementation for stats/base/dists/gumbel/median #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2025
Merged

feat: add C implementation for stats/base/dists/gumbel/median #4152

merged 6 commits into from
Jul 9, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves #3649

Description

  • adds C implementation for @stdlib/stats/base/dists/gumbel/median along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 23, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 23, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gumbel/median $\color{green}182/182$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}182/182$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025
Planeshifter
Planeshifter requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. We can optimize the implementation a little, but otherwise this should be ready to land.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 19, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 20, 2025 19:35
vivekmaurya001 and others added 2 commits January 21, 2025 18:13
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jul 9, 2025
@Planeshifter
chore: minor clean-up
f2ea2e8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter
Planeshifter approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 9, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Jul 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 9, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation for `stats/base/dists/gumbel/median`  

PR-URL: https://github.com/stdlib-js/stdlib/pull/4152
Closes: https://github.com/stdlib-js/stdlib/issues/3649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter changed the title feat: add C implementation for stats/base/dists/gumbel/median feat: add C implementation for stats/base/dists/gumbel/median Jul 9, 2025
@Planeshifter Planeshifter marked this pull request as ready for review July 9, 2025 23:57
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 9, 2025
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Jul 9, 2025
@Planeshifter Planeshifter merged commit 8fcada4 into stdlib-js:develop Jul 9, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/gumbel/median
3 participants
@vivekmaurya001 @stdlib-bot @Planeshifter