Skip to content

refactor: update docs and handling of zero stride of blas/ext/base/dapxsumkbn #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • update documentation
  • update handling of case when stride is equal to zero.
  • update tests according to above change.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 21, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dapxsumkbn $\color{green}392/392$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}392/392$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
Copy link
Member Author

@kgryte The test failure here is from a downstream test suite. I'll update it once this PR is merged.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit f4009fd into stdlib-js:develop Nov 21, 2024
18 of 19 checks passed
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

@headlessNode This is already merged, but I just saw that we are still using fabs in the implementation. We can migrate to using @stdlib/math/base/special/abs.

@headlessNode headlessNode deleted the dapxsumkbn-refactor branch November 21, 2024 10:02
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
…apxsumkbn`

PR-URL: stdlib-js#3212
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants