Skip to content

feat: add iter/cunone-by #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2024
Merged

feat: add iter/cunone-by #2783

merged 4 commits into from
Aug 15, 2024

Conversation

Kaif987
Copy link
Contributor

@Kaif987 Kaif987 commented Aug 12, 2024

This commit adds cunone-by package

Resolves #2337

Description

What is the purpose of this pull request?
The purpose of this pull request is to add the @stdlib/iter/cunone-by package which cumulatively tests whether no iterated value passes a test implemented by a predicate function.

Related Issues

Does this pull request have any related issues?
#2337

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

This commit adds support for creating a
function  which returns an iterator
which cumulatively tests whether no iterated
value passes a test implemented by a predicate function

Fixes: stdlib-js#2337
Private-ref:stdlib-js#2337
@Kaif987
Copy link
Contributor Author

Kaif987 commented Aug 12, 2024

HI @kgryte. Please review my PR

@Kaif987 Kaif987 changed the title feat(iter): add iterCuNoneBy function feat(iter): add @stdlib/iter/cunone-by package Aug 13, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Aug 15, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 15, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @Kaif987. Note, however, that I ended up doing a fair amount of clean-up to get this PR over the finish line. For future contributions, please be sure to follow the project contributing guidelines and pay special attention to project conventions.

@kgryte kgryte changed the title feat(iter): add @stdlib/iter/cunone-by package feat: add iter/cunone-by Aug 15, 2024
@kgryte kgryte merged commit c0de83a into stdlib-js:develop Aug 15, 2024
11 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2783
Closes: stdlib-js#2337
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/iter/cunone-by
2 participants