Skip to content

fix: bug with duplicate tokens when syntax-highlighting in the REPL #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix: bug with duplicate tokens when syntax-highlighting in the REPL #2542

merged 2 commits into from
Jul 9, 2024

Conversation

Snehil-Shah
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • fixes a bug caused by acorn generating duplicate tokens, by processing the tokens before highlighting.
  • updates test case to be receptive to this.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

To reproduce the bug, type any member expression with more than 2 members. ex: base.dists.normal.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
test: update test to catch the bug
c32a5df 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
fix: remove duplicate tokens after tokenizing
9336d67 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@kgryte kgryte added the REPL Issue or pull request specific to the project REPL. label Jul 9, 2024
kgryte
kgryte approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah.

@kgryte kgryte merged commit 3efb708 into stdlib-js:develop Jul 9, 2024
6 checks passed
@Snehil-Shah Snehil-Shah deleted the fix-bug branch July 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
REPL Issue or pull request specific to the project REPL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snehil-Shah @kgryte