-
-
Notifications
You must be signed in to change notification settings - Fork 814
feat: add blas/base/matrix-triangle-str2enum
& blas/base/matrix-triangle/enum2str
#2495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blas/base/matrix-triangle-str2enum
& blas/base/matrix-triangle/enum2str
#2495
Conversation
Repl Lint Failure happens in This happens even if I copy and use https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/blas/base/transpose-operation-enum2str/docs/repl.txt exact same with no modifications. % git commit -m "chore: add docs/repl.txt"
/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js:175
alias = alias.split( '.' );
^
TypeError: Cannot read properties of null (reading 'split')
at replaceAliases (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js:175:18)
at String.replace (<anonymous>)
at replace (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/string/base/replace/lib/main.js:49:13)
at replace (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/string/replace/lib/main.js:78:9)
at Object.returnValues [as validate] (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/_tools/repl-txt/rules/doctest/lib/main.js:131:12)
at Linter.validate (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/_tools/repl-txt/validate/lib/validate.js:110:32)
at isValid (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/_tools/repl-txt/validate/lib/main.js:42:9)
at onRead (/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/_tools/lint/repl-txt/lib/lint.js:93:11)
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read/context:68:3)
Node.js v20.9.0
REPL help lint errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done by copy pasting files from corresponding transpose-operation-*
using cp -r transpose-operation-enum2str/* matrix-triangle-enum2str/
and then find and replace. I am not sure why we have lint error in repl.txt
for enum2str
.
The trouble is in line --- a/lib/node_modules/@stdlib/blas/base/matrix-triangle-enum2str/docs/repl.txt
+++ b/lib/node_modules/@stdlib/blas/base/matrix-triangle-enum2str/docs/repl.txt
@@ -15,7 +15,7 @@
Examples
--------
- > var out = {{alias}}( {{alias:@stdlib/blas/base/matrix-triangle-str2enum}}( 'upper' ) )
+ > var out = {{alias}}( 121 )
'upper'
See Also |
@Pranavchiku This lint error is expected. The package is not yet in the REPL namespace. We can ignore for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Pranavchiku!
Description
This pull request adds implementation for
blas/base/matrix-triangle-str2enum
&blas/base/matrix-triangle/enum2str
Checklist
@stdlib-js/reviewers