feat: add `toLocaleString` method to `array/complex64` #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kgryte merged 8 commits into stdlib-js:develop from Jaysukh-409:toLocaleString

May 4, 2024

Member

Jaysukh-409 commented Apr 27, 2024

Description

What is the purpose of this pull request?

This pull request:

Adds the typed array toLocaleString method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          feat: add toLocaleString method to array/complex64

c679e6f

kgryte added the Feature label

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

04e7703

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved


          Apply suggestions from code review

6b78dab

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved


          Apply suggestions from code review

862a166

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.to_locale_string.js Outdated Show resolved Hide resolved


          Apply suggestions from code review

21117b6

Signed-off-by: Athan <kgryte@gmail.com>

kgryte added the Needs Changes label

kgryte added 3 commits

May 4, 2024 02:28


          refactor: check for an array of strings and avoid reassignment when u…

bd581e7

…sing `arguments`


          test: add tests

b5aff57


          refactor: increase type specificity

fd7862c

kgryte removed the Needs Changes label

kgryte approved these changes

View reviewed changes

Member

kgryte left a comment

LGTM. Thanks, @Jaysukh-409!

kgryte merged commit e92cdd8 into stdlib-js:develop

kgryte deleted the toLocaleString branch

May 23, 2024 20:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature