Skip to content

refactor: update blas/ext/base/sdssum to follow current project conve… #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

refactor: update blas/ext/base/sdssum to follow current project conve… #2080

merged 2 commits into from
Apr 15, 2024

Conversation

AmCodesLame
Copy link
Contributor

Resolves #1525 .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors @stdlib/blas/ext/base/ssorthp to follow current project conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Would you kindly provide guidance on my manifest.json for potential errors? I am not entirely sure about mine. Thank you.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 27, 2024
stdlib-bot
stdlib-bot reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter Planeshifter self-requested a review March 28, 2024 16:57
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 28, 2024
@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/sdssum to follow current project conve… refactor: update blas/ext/base/sdssum to follow current project conve… Mar 29, 2024
Planeshifter
Planeshifter approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 15, 2024
@Planeshifter Planeshifter merged commit c13b428 into stdlib-js:develop Apr 15, 2024
8 checks passed
@Planeshifter Planeshifter mentioned this pull request Apr 20, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sdssum to follow current project conventions
3 participants
@AmCodesLame @Planeshifter @stdlib-bot