Skip to content

refactor update blas/ext/base/dsnansumors follow current project conventions #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 15, 2024
Merged

refactor update blas/ext/base/dsnansumors follow current project conventions #2056

merged 8 commits into from
Apr 15, 2024

Conversation

rajutkarsh07
Copy link
Contributor

Resolves #1493 .

Description

What is the purpose of this pull request?
update blas/ext/base/dsnansumors follow current project conventions

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 26, 2024
@rajutkarsh07
Copy link
Contributor Author

@Planeshifter @kgryte @Pranavchiku Please review this PR

@rajutkarsh07 rajutkarsh07 mentioned this pull request Mar 27, 2024
Closed
6 tasks
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 28, 2024
@rajutkarsh07
Copy link
Contributor Author

@Planeshifter I have made the required changes please review this

@Planeshifter Planeshifter self-requested a review April 14, 2024 21:28
@Planeshifter
Update lib/node_modules/@stdlib/blas/ext/base/dsnansumors/README.md
cbc89f8 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Had to make a bunch of changes to get CI to pass and C benchmarks / examples to compile, but the PR should now be ready to land.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Apr 15, 2024
@Planeshifter Planeshifter merged commit ab3615f into stdlib-js:develop Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dsnansumors to follow current project conventions
3 participants
@rajutkarsh07 @Planeshifter @stdlib-bot