Skip to content

refactor: update blas/ext/base/ssumkbn2 to follow current project conventions #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

refactor: update blas/ext/base/ssumkbn2 to follow current project conventions #1749

wants to merge 8 commits into from

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Mar 7, 2024 •
edited
Loading

…ventions

Resolves # .

Description

What is the purpose of this pull request?

This pull request refactors the @stdlib/blas/ext/ssumkbn2 to follow current project conventions

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@vr-varad vr-varad mentioned this pull request Mar 7, 2024
Closed
3 tasks
@vr-varad
Copy link
Contributor Author

vr-varad commented Mar 7, 2024

Hello @Planeshifter and @kgryte, I'd appreciate your review of my pull request (#1749) whenever you have a moment. Thank you!

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 7, 2024
@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/ssumkbn2 to follow current project conventions refactor: update blas/ext/base/ssumkbn2 to follow current project conventions Mar 8, 2024
@vr-varad
Copy link
Contributor Author

vr-varad commented Mar 9, 2024

Hi @Planeshifter @Pranavchiku and @kgryte, just checking in on my pull request (#1749). Would you mind reviewing it when you get a chance?

@vr-varad
Copy link
Contributor Author

@Planeshifter any updates of reviews?

Pranavchiku
Pranavchiku suggested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes in docs/types, requested few changes.

@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
@vr-varad vr-varad requested a review from Pranavchiku March 12, 2024 15:27
@vr-varad
Copy link
Contributor Author

@kgryte @Planeshifter @Pranavchiku Could u review it for any other issues or changes?

@vr-varad vr-varad requested a review from kgryte March 13, 2024 12:07
@vr-varad
Copy link
Contributor Author

@kgryte I am closing this pr as there is an issue in my forked repository and will make a new pr soon.

@vr-varad vr-varad closed this Mar 13, 2024
@vr-varad vr-varad mentioned this pull request Mar 13, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Awaiting requested review from Pranavchiku

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssumkbn2 to follow current project conventions
4 participants
@vr-varad @kgryte @Pranavchiku @Planeshifter