feat: add support for the typed array `every` method in `array/complex64` #1184

Jaysukh-409 · 2023-12-17T10:41:36Z

Description

What is the purpose of this pull request?

This pull request:

Adds the typed array every method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

lib/node_modules/@stdlib/array/complex64/lib/main.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/lib/main.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/lib/main.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/lib/main.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/lib/main.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/README.md

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/README.md

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/README.md

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts

lib/node_modules/@stdlib/array/complex64/lib/main.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/array/complex64/test/test.every.js

Signed-off-by: Athan <kgryte@gmail.com>

kgryte

LGTM. Thanks, @Jaysukh-409!

feat: add support for the typed array every method in array/complex64

1f53999

kgryte added the Feature Issue or pull request for adding a new feature. label Dec 17, 2023

kgryte self-requested a review December 17, 2023 10:43

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

Apply suggestions from code review

53a8044

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

Apply suggestions from code review

97989b0

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

Apply suggestions from code review

30bddf7

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

Apply suggestions from code review

7221da5

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 17, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

kgryte and others added 2 commits December 17, 2023 02:53

Apply suggestions from code review

67d50b8

Signed-off-by: Athan <kgryte@gmail.com>

feat: updated README and Typescript declaration and added benchmark

09d968a

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

dbe3004

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

kgryte added 2 commits December 17, 2023 19:44

Apply suggestions from code review

0b5abfe

Signed-off-by: Athan <kgryte@gmail.com>

Apply suggestions from code review

080ca06

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

3bc51ab

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js Outdated Show resolved Hide resolved

Apply suggestions from code review

16215ca

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js Outdated Show resolved Hide resolved

Apply suggestions from code review

defa47e

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js Outdated Show resolved Hide resolved

Apply suggestions from code review

fa7a0d6

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.every.js Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte and others added 7 commits December 17, 2023 19:57

refactor: move method to ensure methods are in alphabetical order

0ca60a4

refactor: abstract logic into internal function

032bbec

refactor: improve TypeScript declarations

e329f94

refactor: update TypeScript declarations for from

3406be7

style: remove extraneous spaces

37cde25

bench: add length benchmarks and update annotations

4da554a

feat: add test to the array/complex64

84fbebf

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/lib/main.js Outdated Show resolved Hide resolved

Apply suggestions from code review

0646e31

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.every.js Outdated Show resolved Hide resolved

kgryte reviewed Dec 18, 2023

View reviewed changes

lib/node_modules/@stdlib/array/complex64/test/test.every.js Outdated Show resolved Hide resolved

Apply suggestions from code review

babf221

Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes Dec 18, 2023

View reviewed changes

kgryte merged commit 9272073 into stdlib-js:develop Dec 18, 2023

kgryte deleted the complexEvery branch December 18, 2023 06:11

Uh oh!

feat: add support for the typed array every method in array/complex64 #1184

feat: add support for the typed array every method in array/complex64 #1184

Uh oh!

Conversation

Jaysukh-409 commented Dec 17, 2023 • edited by kgryte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: add support for the typed array `every` method in `array/complex64` #1184

feat: add support for the typed array `every` method in `array/complex64` #1184

Jaysukh-409 commented Dec 17, 2023 •

edited by kgryte

Loading