-
-
Notifications
You must be signed in to change notification settings - Fork 822
feat: add array/base/last
#1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If applied, this commit will bring in the changes to return the last element from an array like object. Closes: #858
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Welcome! 🎉
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/base/last/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Infinage!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Infinage!
array/base/last
Thanks for the review and the merge @kgryte! I will take better care of the edge cases and add better examples the next time. Most of the changes you did made sense. But I am just curious about these two changes:
|
@Infinage Regarding changes,
For now, you do not need to rename the file. I can take care of that on my end. Hope this answers your questions. |
Yes it does, thanks! |
Description
This pull request:
Related Issues
This pull request:
@stdlib/array/base/last
#858Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers