Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for usernames with spaces. #38

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

zsavely
Copy link
Contributor

@zsavely zsavely commented Nov 11, 2016

If a Windows user has a space character in the username,

  1. userprofile breaks into 2 variables and must be saved with " ".
  2. call :copy_config is supplied with an argument but if there is a space in the argument value, it breaks into 2 arguments.
  3. command xcopy /s configs C:\Users\John Doe is also supplied with 2 arguments because of the space character.

If a Windows user has a space character in the username,

1. `userprofile` breaks into 2 variables and must be saved with `" "`.
2. `call :copy_config` is supplied with an argument but if there is a space in the argument value, it breaks into 2 arguments.
3. command `xcopy /s configs C:\Users\John Doe` is also supplied with 2 arguments because of the space character.
@JakeWharton JakeWharton merged commit db83654 into square:master Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants