Skip to content

Conversation

brody4hire
Copy link

git grep shows the outdated opensslVersion used in only one place, looks safe to remove

(I am actually trying to build an updated version in my workarea, with Android NDK r23 which seems to be their latest LTS, as I make this PR)

While I don't anticipate this to break anything, I am raising this as a draft PR NOT TESTED until I get a chance to test this from start to finish. In case a maintainer feels confident to apply this proposal now WITH AN UPDATED TITLE, that would be awesome as well.

And thanks to @developernotes for updating SQLCIPHER_ANDROID_VERSION in the documentation.

@brody4hire brody4hire changed the title [DRAFT NOT TESTED] remove outdated opensslVersion from build.gradle - DRAFT NOT TESTED remove outdated opensslVersion from build.gradle Aug 30, 2021
@brody4hire brody4hire marked this pull request as ready for review August 30, 2021 23:43
@brody4hire brody4hire force-pushed the remove-outdated-openssl-version-from-build branch from 16a6c4e to bebb197 Compare August 30, 2021 23:43
@brody4hire
Copy link
Author

I have rebased this update and tested building (tested building with Android NDK r23, with -fuse-ld=bfd removed to succeed with NDK r23), would appreciate a review ... thanks.

@developernotes
Copy link
Member

Hi @brodybits

That is correct, the opensslVersion referenced in the Gradle file is an artifact from the library when it directly bundled an OpenSSL source package. Now that you must externally provide an OpenSSL source tree, that variable is no longer necessary. Thanks!

@developernotes developernotes merged commit ce7026a into sqlcipher:master Aug 31, 2021
@brody4hire brody4hire deleted the remove-outdated-openssl-version-from-build branch January 9, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants