Fix postgresql time #1623
Closed
Fix postgresql time #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
reviewed
Aug 29, 2022
|
Going to close this PR. We'll address this when adding support for pgx/v5 |
6 tasks
|
Having it fixed with pgx/v5 sounds good. But is there any reason why we cannot merge this (realtively small change) now so that it already works with this version? |
|
The reason I don't want to merge this is the unclear future of the pgtype package. I grieve it will be deprecated in less than a week. |
|
Hey, so jackc has continued to maintain pgtype, but we've since landed some pgx/v5 support, so we can update this PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's
time.Timetype is not compatible with Postgres'pg_catalog.timetype. Therefore this fix usespgtype.Timewhich is the correct one.pg_catalog.timetzwould also need to be fixed, but there is nopgtype.TimeTZ(see jackc/pgtype#150 and jackc/pgx#759).