update Chinese translation for Bravo #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date localization json adjusted and slight change for Bravo UI
adamsmodi
requested review from
danieleperilli and
albertospelta
as code owners
albertospelta
approved these changes
Nov 29, 2022
|
Hi @adamsmodi, thanks for this PR and for updating Chinese translation! I hope you can find a solution to keep accessing GitHub!
Thanks for pointing it out! I just checked and realized that the date localization changes were inadvertently overwritten with the merge of PR #480. I will fix this as soon as I can. Thanks Adams! |
danieleperilli
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear SQL BI team,
big congratulation to see the Bravo v1.0 ! Sorry for the late thank U because I am now back to China. I was seeking a solution to continue to access GitHub and YouTube.
Recently, I figured out that some translation don't work any more. There are of course some new columns added in Date Template but I can not find some translation which were merged with my pull request #444 either. It is a little bit weird for me, is there some specific reason which I am not aware about ?
Anyway I try now again to adjust Date localization json file and make some slight changes for Bravo UI.
Would it still be possible for you to take a look and merge it ? I realize now there is custom template function, but I still prefer to make the default date template translation correct.
Sorry for bothering again and greeting you guys again from China !
BR.
Adams Modi