Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Chinese translation for Bravo #547

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

adamsmodi
Copy link
Contributor

Dear SQL BI team,

big congratulation to see the Bravo v1.0 ! Sorry for the late thank U because I am now back to China. I was seeking a solution to continue to access GitHub and YouTube.

Recently, I figured out that some translation don't work any more. There are of course some new columns added in Date Template but I can not find some translation which were merged with my pull request #444 either. It is a little bit weird for me, is there some specific reason which I am not aware about ?

Anyway I try now again to adjust Date localization json file and make some slight changes for Bravo UI.

Would it still be possible for you to take a look and merge it ? I realize now there is custom template function, but I still prefer to make the default date template translation correct.

Sorry for bothering again and greeting you guys again from China !

BR.
Adams Modi

Date localization json adjusted and slight change for Bravo UI
@albertospelta
Copy link
Collaborator

Hi @adamsmodi, thanks for this PR and for updating Chinese translation! I hope you can find a solution to keep accessing GitHub!

I can not find some translation which were merged with my pull request #444 either. It is a little bit weird for me, is there some specific reason which I am not aware about?

Thanks for pointing it out! I just checked and realized that the date localization changes were inadvertently overwritten with the merge of PR #480. I will fix this as soon as I can.

Thanks Adams!

@albertospelta albertospelta added this to the v1.0.1 milestone Nov 29, 2022
@albertospelta albertospelta merged commit f917520 into sql-bi:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants