Avoid unnecessary CGLIB processing on configuration classes #34486
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
status: backported
An issue that has been backported to maintenance branches
type: enhancement
A general enhancement
Milestone
Comments
jhoeller
added
in: core
jhoeller
added
the
for: backport-to-6.1.x
github-actions
bot
added
status: backported
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Mar 29, 2025
This commit addresses a regression introduced in 6.2.4 in conjunction with spring-projects#34486. See spring-projectsgh-34486 Closes spring-projectsgh-34663
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Mar 31, 2025
Historically, @Configuration classes that did not declare @Bean methods were allowed to be abstract. However, the changes made in 76a6b9ea79 introduced a regression that prevents such classes from being abstract, resulting in a BeanInstantiationException. This change in behavior is caused by the fact that such a @Configuration class is no longer replaced by a concrete subclass created dynamically by CGLIB. This commit restores support for abstract @Configuration classes without @Bean methods by modifying the "no enhancement required" check in ConfigurationClassParser. See spring-projectsgh-34486 Closes spring-projectsgh-34663
sbrannen
added a commit
that referenced
this issue
Mar 31, 2025
Historically, @Configuration classes that did not declare @Bean methods were allowed to be abstract. However, the changes made in 76a6b9ea79 introduced a regression that prevents such classes from being abstract, resulting in a BeanInstantiationException. This change in behavior is caused by the fact that such a @Configuration class is no longer replaced by a concrete subclass created dynamically by CGLIB. This commit restores support for abstract @Configuration classes without @Bean methods by modifying the "no enhancement required" check in ConfigurationClassParser. See gh-34486 Closes gh-34663
sbrannen
added a commit
that referenced
this issue
Mar 31, 2025
Historically, @Configuration classes that did not declare @Bean methods were allowed to be abstract. However, the changes made in 76a6b9ea79 introduced a regression that prevents such classes from being abstract, resulting in a BeanInstantiationException. This change in behavior is caused by the fact that such a @Configuration class is no longer replaced by a concrete subclass created dynamically by CGLIB. This commit restores support for abstract @Configuration classes without @Bean methods by modifying the "no enhancement required" check in ConfigurationClassParser. See gh-34486 Closes gh-34663 (cherry picked from commit 044258f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a
@Configurationclass does not declare (or inherit) any instance-level@Beanmethods, generating an enhanced subclass with CGLIB is not adding any value. This is particularly likely for "holder"-like configuration classes with just imports, not least of it all common@SpringBootApplicationclasses. We can entirely skip CGLIB processing for such classes, also not incurring unnecessary potential for CGLIB class cache failures/fallbacks (#34423).The text was updated successfully, but these errors were encountered: