Skip to content

DATAMONGO-2021 - Use getObjectId() instead of getFilename() #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAMONGO-2021 - Use getObjectId() instead of getFilename() #581

wants to merge 1 commit into from

Conversation

nhh
Copy link
Contributor

@nhh nhh commented Jul 6, 2018

Using the file name leads to duplicate resource streams as file names
are not unique.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [] You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@nhh
DATAMONGO-2021 - Use getObjectId() instead of getFilename()
dfff30c 
Using the file name leads to duplicate resource streams as file names
are not unique.
mp911de pushed a commit that referenced this pull request Jul 6, 2018
@nhh @mp911de
DATAMONGO-2021 - Use getObjectId() instead of getFilename() for openi…
1a3b9e3 
…ng the GridFS download stream.

Using the file name leads to duplicate resource streams as file names are not unique therefore we're using the file's ObjectId to lookup the file content.

Original pull request: #581.
mp911de added a commit that referenced this pull request Jul 6, 2018
@mp911de
DATAMONGO-2021 - Polishing.
6f011b0 
Adapt getResources(…) to use the file id and no longer the file name when opening a download stream. Add author tag.

Original pull request: #581.
mp911de pushed a commit that referenced this pull request Jul 6, 2018
@nhh @mp911de
DATAMONGO-2021 - Use getObjectId() instead of getFilename() for openi…
e18f506 
…ng the GridFS download stream.

Using the file name leads to duplicate resource streams as file names are not unique therefore we're using the file's ObjectId to lookup the file content.

Original pull request: #581.
mp911de added a commit that referenced this pull request Jul 6, 2018
@mp911de
DATAMONGO-2021 - Polishing.
0ec82e1 
Adapt getResources(…) to use the file id and no longer the file name when opening a download stream. Add author tag. Add test to verify content retrieval by identity.

Original pull request: #581.
@mp911de
Copy link
Member

mp911de commented Jul 6, 2018

Thanks a lot. That's merged, polished, and backported now.

@mp911de mp911de closed this Jul 6, 2018
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhh @mp911de