DATAMONGO-1919 - Allow reactive-only usage of ReactiveMongoTemplate. #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| simpleTypes.add(org.bson.Document.class); | ||
| simpleTypes.add(Pattern.class); | ||
| simpleTypes.add(Binary.class); | ||
| simpleTypes.add(UUID.class); | ||
|
|
||
| if (ClassUtils.isPresent("org.bson.types.CodeWScope", MongoSimpleTypes.class.getClassLoader())) { |
There was a problem hiding this comment.
Looking at the latest driver bits, those changes here do not seem to be necessary any longer. Comparing the org.bson packages of org.mongodb:mongo-java-driver:3.8.0 and org.mongodb:bson:3.8.0 shows no difference at all.
I think we should wait until #576 is resolved.
We now support reactive-only usage of Spring Data MongoDB without the need to use the synchronous driver or even having it on the class path. We conditionally register CodeWScope/CodeWithScope types that are bundled with the particular driver distributions. NoOpDbRefResolver is now a top-level type to be used with a reactive-only MongoMappingContext.
Fix typo, use diamond syntax where possible.
Remove unused imports, deprecated MongoClientVersion methods for drivers no longer supported and remove their usage throughout the codebase and partially revert changes in MongoSimpleTypes because all org.bson types have been included in the 3.8 release of com.mongodb.bson.
christophstrobl
force-pushed
the
issue/DATAMONGO-1919
branch
from
374152a to
5f2d183
Compare
christophstrobl
pushed a commit
that referenced
this pull request
Jul 2, 2018
We now support reactive-only usage of Spring Data MongoDB without the need to use the synchronous driver or even having it on the class path. We conditionally register CodeWScope/CodeWithScope types that are bundled with the particular driver distributions. NoOpDbRefResolver is now a top-level type to be used with a reactive-only MongoMappingContext. Original Pull Request: #572
christophstrobl
pushed a commit
that referenced
this pull request
Jul 2, 2018
Fix typo, use diamond syntax where possible. Original Pull Request: #572
christophstrobl
added a commit
that referenced
this pull request
Jul 2, 2018
Remove unused imports, deprecated MongoClientVersion methods for drivers no longer supported and remove their usage throughout the codebase and partially revert changes in MongoSimpleTypes because all org.bson types have been included in the 3.8 release of org.mongodb.bson. Original Pull Request: #572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support reactive-only usage of Spring Data MongoDB without the need to use the synchronous driver or even having it on the class path. We conditionally register
CodeWScope/CodeWithScopetypes that are bundled with the particular driver distributions.NoOpDbRefResolveris now a top-level type to be used with a reactive-onlyMongoMappingContext.Related ticket: DATAMONGO-1919.