-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DATAMONGO-1824 - Assert compatibility with MongoDB 3.6 #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…driver call to support MongoDB 3.6. We now use the driver native option for aggregate instead of a plain command execution. This is necessary as of MongoDB 3.6 the cursor option is required for aggregations changing the return and execution model. Still we maintain the raw values of AggregationResult as we used to do before. However, relying on executeCommand to change aggregation behavior in custom code will no longer work. Tested against MongoDB: 3.6.RC3, 3.4.9 and 3.2.6 Along the the way we opened up Aggregation itself to expose the AggregationOptions in use und deprecated the $pushAll option on Update since it has been removed in MongoDB 3.6.
Introduce Aggregation.toPipeline(…) method to render the aggregation pipeline directly. Adapt code using aggregation pipelines. Consider allowDiskUse and batchSize cursor options. Move introduction versions to 2.1. Mention migration to cursor-based aggregation in reference docs.
mp911de
pushed a commit
that referenced
this pull request
Nov 17, 2017
…llection.aggregate(…) to support MongoDB 3.6. We now use the driver native option for aggregate instead of a plain command execution. This is necessary as of MongoDB 3.6 the cursor option is required for aggregations changing the return and execution model. Still we maintain the raw values of AggregationResult as we used to do before. However, relying on executeCommand to change aggregation behavior in custom code will no longer work. Tested against MongoDB: 3.6.RC3, 3.4.9 and 3.2.6 Along the the way we opened up Aggregation itself to expose the AggregationOptions in use und deprecated the $pushAll option on Update since it has been removed in MongoDB 3.6. Original pull request: #515.
mp911de
added a commit
that referenced
this pull request
Nov 17, 2017
Introduce Aggregation.toPipeline(…) method to render the aggregation pipeline directly. Adapt code using aggregation pipelines. Consider allowDiskUse and batchSize cursor options. Move introduction versions to 2.1. Mention migration to cursor-based aggregation in reference docs. Original pull request: #515.
That's merged and polished now. |
But The Project is Compiler by jdk 1.7, Version 2.0+ not supported |
Can you release a version that supports jdk 1. 7 |
These changes are also shipped with Spring Data MongoDB version 1.10.10 and higher requiring Java 6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the driver native option for
aggregate
instead of a plain command execution. This is necessary as of MongoDB 3.6 the cursor option is required for aggregations changing the return and execution model.Still we maintain the raw values of
AggregationResult
as we used to do before. However, relying onexecuteCommand
to change aggregation behavior in custom code will no longer work.Along the the way we opened up
Aggregation
itself to expose theAggregationOptions
in use und deprecated the$pushAll
option onUpdate
since it has been removed in MongoDB 3.6.Tested against MongoDB: 3.6.RC3, 3.4.9 and 3.2.6