Skip to content

DATAMONGO-1817 - Kotlin extensions should return nullable types #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAMONGO-1817 - Kotlin extensions should return nullable types #510

wants to merge 1 commit into from

Conversation

unlimitedsola
Copy link
Contributor

@unlimitedsola unlimitedsola commented Oct 28, 2017 •
edited
Loading

Signed-off-by: Sola dev@sola.love

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@mp911de mp911de self-assigned this Nov 6, 2017
@mp911de
Copy link
Member

mp911de commented Nov 6, 2017

Thanks for your pull request. Could you provide us with your full name (in the Latin alphabet)?

mp911de pushed a commit that referenced this pull request Nov 6, 2017
@unlimitedsola @mp911de
DATAMONGO-1817 - Align nullability in Kotlin MongoOperationsExtension…
7104ffa 
…s with Java API.

Return types in MongoOperationsExtensions are now aligned to the nullability of MongoOperations.

Original pull request: #510.
mp911de added a commit that referenced this pull request Nov 6, 2017
@mp911de
DATAMONGO-1817 - Polishing.
c0cf1aa 
Remove blank line.

Original pull request: #510.
mp911de pushed a commit that referenced this pull request Nov 6, 2017
@unlimitedsola @mp911de
DATAMONGO-1817 - Align nullability in Kotlin MongoOperationsExtension…
f79dc39 
…s with Java API.

Return types in MongoOperationsExtensions are now aligned to the nullability of MongoOperations.

Original pull request: #510.
mp911de added a commit that referenced this pull request Nov 6, 2017
@mp911de
DATAMONGO-1817 - Polishing.
6b3ec31 
Remove blank line.

Original pull request: #510.
@unlimitedsola
Copy link
Contributor Author

currently I don't have a real name in English
(・_・;)

@mp911de
Copy link
Member

mp911de commented Nov 6, 2017

Seems that we can get away with an obvious fix for now (in regard to the CLA). That's merged, polished and back-ported now.

@mp911de mp911de closed this Nov 6, 2017
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unlimitedsola @mp911de