DATAMONGO-1726 - Add oneValue() & findValue() to FluentMongo API returning null instead of Optional. #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning null instead of Optional. We leave the choice of using Optional open by also providing terminating find operation methods that retur null instead of Optional.
|
LGTM, except the commit message stating |
mp911de
pushed a commit
that referenced
this pull request
Jul 6, 2017
…ions returning nullable types. We leave the choice of using Optional open by also providing terminating find operation methods that return null instead of Optional. Original pull request: #475.
|
That's merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leave the choice of using
Optionalopen by also providing terminating find operation methods that returnnullinstead ofOptional.