DATAMONGO-1687 DATAMONGO-1693 - Initialize collation in CollectionOptions eagerly. #462
+193
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
changed the title
…s.empty().capped(…). Prepare issue branch.
CollectionOptions.collation is initialized with Optional.empty() to guard collection creation against null dereference.
CollectionOptions is now immutable and returns Optional#empty for values not set. Some minor changes to JavaDoc and required updates for tests involved.
…lection. We now consider CollectionOptions.collation via ReactiveMongoTemplate.createCollection.
christophstrobl
force-pushed
the
issue/DATAMONGO-1687
branch
from
09ac908 to
f1c0500
Compare
christophstrobl
pushed a commit
that referenced
this pull request
May 24, 2017
CollectionOptions.collation is initialized with Optional.empty() to guard collection creation against null dereference. Original Pull Request: #462
christophstrobl
added a commit
that referenced
this pull request
May 24, 2017
CollectionOptions is now immutable and returns Optional#empty for values not set. Some minor changes to JavaDoc and required updates for tests involved. Original Pull Request: #462.
christophstrobl
pushed a commit
that referenced
this pull request
May 24, 2017
…lection. We now consider Collation via CollectionOptions when creating collections using ReactiveMongoTemplate.createCollection. Original Pull Request: #462.
This was referenced Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectionOptions.collationis initialized withOptional.empty()to guard collection creation against null dereference.Related ticket: DATAMONGO-1687