Skip to content

Introduce support for property-based converters #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Introduce support for property-based converters #3982

wants to merge 7 commits into from

Conversation

christophstrobl
Copy link
Member

This PR leverages the infrastructure provided by data-commons to introduce conversions that target only specific properties of an entity. This allows a more fine grained control over the conversion and is an addition to the already existing reading & writing converter API.

Depends On: spring-projects/spring-data-commons#2566

@christophstrobl christophstrobl requested a review from mp911de March 2, 2022 14:18
mp911de
mp911de reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really neat and stores require a very slim implementation. Great work!

Requires a bit of reformatting.

@mp911de mp911de marked this pull request as ready for review March 18, 2022 08:26
@mp911de mp911de self-assigned this Mar 18, 2022
mp911de pushed a commit that referenced this pull request Mar 21, 2022
@christophstrobl @mp911de
Add support for PropertyValueConverters.
29fb085 
Closes: #3596
Original pull request: #3982.
mp911de added a commit that referenced this pull request Mar 21, 2022
@mp911de
Polishing.
8672808 
Reformat code. Tweak documentation wording.

See #3596
Original pull request: #3982.
mp911de pushed a commit that referenced this pull request Mar 21, 2022
@christophstrobl @mp911de
Add support for PropertyValueConverters.
f58e462 
Closes: #3596
Original pull request: #3982.
mp911de added a commit that referenced this pull request Mar 21, 2022
@mp911de
Polishing.
3b0d1e0 
Reformat code. Tweak documentation wording.

See #3596
Original pull request: #3982.
@mp911de mp911de changed the title Introduce support for property based converters. Introduce support for property-based converters Mar 21, 2022
@mp911de mp911de linked an issue Mar 21, 2022 that may be closed by this pull request
Select converter based on custom annotation rather than object class #3596
Closed
@mp911de
Copy link
Member

mp911de commented Mar 21, 2022

That's merged, polished, and forward-ported now.

@mp911de mp911de closed this Mar 21, 2022
@mp911de mp911de deleted the issue/3596 branch March 21, 2022 08:33
@mp911de mp911de added the type: enhancement A general enhancement label Mar 21, 2022
@mp911de mp911de added this to the 3.4 M4 (2021.2.0) milestone Mar 21, 2022
@christophstrobl christophstrobl mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 M4 (2021.2.0)
Development

Successfully merging this pull request may close these issues.

Select converter based on custom annotation rather than object class
2 participants
@christophstrobl @mp911de