Translate MongoSocketException subclasses to DataAccessResourceFailureException #3569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
(sorry I'm new on this project) I'm unable to see UT+IT results from github PR checks list. Are they executed somewhere? |
mp911de
requested changes
Mar 1, 2021
...ta-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoExceptionTranslator.java
Outdated
Show resolved
Hide resolved
...ta-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoExceptionTranslator.java
Outdated
Show resolved
Hide resolved
mp911de
added
type: enhancement
mp911de
changed the title
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3568
Improve
MongoExceptionTranslatorto accept direct children is some case. First use case :MongoSocketException, MongoSocketException$children.NB/ historical contributors of this class: @christophstrobl, @michalvich, @odrotbohm (Oliver Gierke)