DATA-1293 - Allowed id attribute in addition to client-uri attribute in MongoDbFactoryParser. #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in MongoDbFactoryParser. Additionally, the previous approach allowed any attribute to be set if write-concern attribute was set. Fixed that also.
| @@ -73,7 +74,10 @@ protected AbstractBeanDefinition parseInternal(Element element, ParserContext pa | |||
| BeanDefinition mongoUri = getMongoUri(element); | |||
|
|
|||
| if (mongoUri != null) { | |||
| if (element.getAttributes().getLength() >= 2 && !element.hasAttribute("write-concern")) { | |||
There was a problem hiding this comment.
Can we rather white-list the allowed attributes?
…of allowed attributes and compare it to total attributes count.
|
thanks @vkhoroshko! |
christophstrobl
pushed a commit
that referenced
this pull request
Oct 29, 2015
…bute in MongoDbFactoryParser. We now allow write-concern and id to be configured along with the uri or client-uri attribute of <mongo:db-factory. Original Pull Request: #328 CLA: 140120150929074128 (Viktor Khoroshko)
christophstrobl
added a commit
that referenced
this pull request
Oct 29, 2015
Move configuration parsing error into method actually responsible for reading uri/client-uri attributes. Original Pull Request: #328
christophstrobl
pushed a commit
that referenced
this pull request
Oct 29, 2015
…bute in MongoDbFactoryParser. We now allow write-concern and id to be configured along with the uri or client-uri attribute of <mongo:db-factory. Original Pull Request: #328 CLA: 140120150929074128 (Viktor Khoroshko)
christophstrobl
added a commit
that referenced
this pull request
Oct 29, 2015
Move configuration parsing error into method actually responsible for reading uri/client-uri attributes. Original Pull Request: #328
|
pushed to master and back ported to 1.8.x (gosling). thanks @vkhoroshko ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, the previous approach allowed any attribute to be set if write-concern attribute was set. Fixed that also.