DATAMONGO-1257 - mongo:mongo-client namespace does not support usernames with a comma. #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes with a comma. Prepare issue branch.
…mes with a comma. We now allow grouping credentials by enclosing them in single quotes. credentials='CN=myName,OU=myOrgUnit,O=myOrg,L=myLocality,ST=myState,C=myCountry?uri.authMechanism=MONGODB-X509' We also changed the required argument checks to be more authentication mechanism specific which means the pattern is now username[:password@database][?options].
christophstrobl
added a commit
that referenced
this pull request
Jul 24, 2015
…s with a comma. We now allow grouping credentials by enclosing them in single quotes like this: credentials='CN=myName,OU=myOrgUnit,O=myOrg,L=myLocality,ST=myState,C=myCountry?uri.authMechanism=MONGODB-X509' We also changed the required argument checks to be more authentication mechanism specific which means the pattern is now username[:password@database][?options]. Original pull request: #310.
odrotbohm
added a commit
that referenced
this pull request
Jul 24, 2015
Made internal helper methods in MongoCredentialPropertyEditor static where possible. Original pull request: #310.
christophstrobl
added a commit
that referenced
this pull request
Jul 24, 2015
…s with a comma. We now allow grouping credentials by enclosing them in single quotes like this: credentials='CN=myName,OU=myOrgUnit,O=myOrg,L=myLocality,ST=myState,C=myCountry?uri.authMechanism=MONGODB-X509' We also changed the required argument checks to be more authentication mechanism specific which means the pattern is now username[:password@database][?options]. Original pull request: #310.
odrotbohm
added a commit
that referenced
this pull request
Jul 24, 2015
Made internal helper methods in MongoCredentialPropertyEditor static where possible. Original pull request: #310.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow grouping credentials by enclosing them in single quotes.
We also changed the required argument checks to be more authentication mechanism specific which means the pattern is now
username[:password@database][?options].