DATATMONGO-1057 - Fix SliceExecution skipping every N+1 element. #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
We now directly set the offset to use instead of reading it from the used pageable. This asserts that every single element is read from the store. Prior to this change the altered pageSize lead to an unintended increase of the number of elements to skip.
christophstrobl
added a commit
that referenced
this pull request
Oct 8, 2014
We now directly set the offset to use instead of reading it from the used pageable. This asserts that every single element is read from the store. Prior to this change the altered pageSize lead to an unintended increase of the number of elements to skip. Original pull request: #226.
odrotbohm
added a commit
that referenced
this pull request
Oct 8, 2014
Slightly tweaked the changes in SlicedExecution to simplify the implementation. We now apply the given pageable but tweak the limit the query uses to peek into the next page. Original pull request: #226.
christophstrobl
added a commit
that referenced
this pull request
Oct 8, 2014
We now directly set the offset to use instead of reading it from the used pageable. This asserts that every single element is read from the store. Prior to this change the altered pageSize lead to an unintended increase of the number of elements to skip. Original pull request: #226.
odrotbohm
added a commit
that referenced
this pull request
Oct 8, 2014
Slightly tweaked the changes in SlicedExecution to simplify the implementation. We now apply the given pageable but tweak the limit the query uses to peek into the next page. Original pull request: #226.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now directly set the offset to use instead of creating a new
Pageable. This asserts that every single element is read from the store.Prior to this change the altered pageSize lead to an unintended increase of elements to skip.