DATAMONGO-1050 - Explicitly annotated Field should not be considered Id. #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdarimont
force-pushed
the
issue/DATAMONGO-1050
branch
from
5df44e6 to
0dd51fb
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Oct 2, 2014
Added tests to ensure proper field mapping for various "id" field variants. Original pull request: #225.
Prepare issue branch.
We changed the id resolution to skip properties having an explicit name set via @field unless they are marked with @id. This means that @field(“id”) String id; will be stored as “id” within mongodb. Prior to this change the fieldname would have been changed to “_id”. Added tests to ensure proper field mapping for various "id" field variants. Original pull request: #225.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1050
branch
from
acce5b2 to
bc73d24
Compare
christophstrobl
added a commit
that referenced
this pull request
Oct 23, 2014
We changed the id resolution to skip properties having an explicit name set via @field unless they are marked with @id. This means that @field(“id”) String id; will be stored as “id” within mongodb. Prior to this change the fieldname would have been changed to “_id”. Added tests to ensure proper field mapping for various "id" field variants. Original pull request: #225.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the id resolution to skip properties having an explicit name set via
@Fieldunless they are marked with@Id. This means that@Field("id") String id;will now be stored as id within MongoDB.Prior to this change the fieldname would have been changed to _id.