DATAMONGO-925 - Improveed custom field-naming-strategy handling in MappingMongoConverterParser. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2014 15:56
…field-naming-strategy-ref in XML configuration. Prepare issue branch.
…ppingMongoConverterParser. Relaxed precondition for fieldNameStrategy setting to allow custom-field-naming strategies to be set. MappingMongoConverterParser incorrectly rejected a configured field-naming-strategy-ref if abbreviate-field-names was not set to an empty string in XML configuration. Original pull request: #177.
odrotbohm
pushed a commit
that referenced
this pull request
May 19, 2014
…ames from namespace XSD. The default for boolean attributes leaks into the evaluation of XML namespace attributes which causes us being unable to detect whether two attributes have been set in a conflicting way. Fix the documentation on the field-naming-strategy-ref attribute. Original pull request: #183. Related pull request: #177. Related ticket: DATAMONGO-925.
odrotbohm
added a commit
that referenced
this pull request
May 19, 2014
Only reject attribute setup if abbreviation is activated and a custom strategy is configured. Additional test cases for the rejection case and a custom, over-configuration (explicitly setting abbreviation to false, which is the default anyway). Related pull request: #177.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxed precondition for fieldNameStrategy setting to allow custom-field-naming strategies to be set.
MappingMongoConverterParser incorrectly rejected a configured field-naming-strategy-ref if abbreviate-field-names was not set to an empty string in XML configuration.