DATAMONGO-892 - Provide meaningful error message when registering converter as nested bean. #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
Register mapping converter as uniquely named bean in context and wire conversions correctly to avoid overriding existing ones.
…verter as nested bean. Mapping information is potentially required by multiple instances and should not be registered within a template as nested bean. The current solution did throw a misleading error which has been corrected. Original Pull Request: #165
Member
|
LGTM! |
christophstrobl
added a commit
that referenced
this pull request
Apr 15, 2014
Mapping information is potentially required by multiple instances and thus must not be registered as nested bean. We now actively check for such an invalid scenario and explicitly reject it. Original pull request: #165.
christophstrobl
added a commit
that referenced
this pull request
Apr 15, 2014
Mapping information is potentially required by multiple instances and thus must not be registered as nested bean. We now actively check for such an invalid scenario and explicitly reject it. Original pull request: #165.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping information is potentially required by multiple instances and should not be registered within a
Templateas nested bean. The current solution did throw a misleading error which has been corrected.