DATAMONGO-888 - Mapping should be applied to Sort. #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
'EntityBackedSortConverter', as an instance of 'SortConverter', takes care of mapping properties to the according names to be used with mongodb. Conversion will inspect properties within the backing entity to resolve ids and additional mapping information within the 'Field' annotation and apply those to the resulting 'DBObject'. The converter will not touch any properties unknown to the backing entity. 'Query.getSortObject()' has been deprecated and will be removed in a subsequent version. Original Pull Request: #162
|
Shouldn't it be sufficient to simply pipe the sort object through the |
christophstrobl
added a commit
that referenced
this pull request
Apr 3, 2014
Query.getSortObject() is passed through QueryMapper in order to retrieve mapped field values. Original Pull Request: #162
Query.getSortObject() is passed through QueryMapper in order to retrieve mapped field values. Original Pull Request: #162
|
@olivergierke yes that would have done it. Changed to proposed solution. Only drop of bitterness that |
christophstrobl
added a commit
that referenced
this pull request
Apr 10, 2014
We now pipe the DBObject containing sorting information for queries through the QueryMapper to make sure potential field mappings are applied. Original Pull Request: #162.
christophstrobl
added a commit
that referenced
this pull request
Apr 10, 2014
We now pipe the DBObject containing sorting information for queries through the QueryMapper to make sure potential field mappings are applied. Original Pull Request: #162.
christophstrobl
added a commit
that referenced
this pull request
May 9, 2014
Additional test added to check if the issue has truly been resolved by DATAMONGO-888 (Pull Request: #162).
christophstrobl
added a commit
that referenced
this pull request
May 9, 2014
…te collection. The issue has been solved along with DATAMONGO-888 (Pull Request: #162). We have created additional tests to explicitly check it has truly been fixed.
christophstrobl
added a commit
that referenced
this pull request
May 19, 2014
…orrectly. Additional test added to check if the issue has truly been resolved by DATAMONGO-888. Original pull request: #181. Related pull Request: #162. Related ticket: DATAMONGO-888.
christophstrobl
added a commit
that referenced
this pull request
May 19, 2014
…orrectly. Additional test added to check if the issue has truly been resolved by DATAMONGO-888. Original pull request: #181. Related pull Request: #162. Related ticket: DATAMONGO-888.
christophstrobl
added a commit
that referenced
this pull request
May 19, 2014
…te collection. The issue has been solved along with DATAMONGO-888 (Pull Request: #162). We have created additional tests to explicitly check it has truly been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query.getSortObject()is passed throughQueryMapperin order to retrieve mapped field values.Should be applied to both
masterand1.4.x.