Relaxing error message comparison so that test passes against MongoDB 2.6 #160
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es against the message returned by MongoDB 2.6.
christophstrobl
pushed a commit
that referenced
this pull request
Apr 3, 2014
Upgrade driver in profile to rc3. Relaxing error message comparison in assertion so that it still matches against the message returned by MongoDB 2.6. Original Pull Request: #160 (Jeff Yemin)
odrotbohm
pushed a commit
that referenced
this pull request
Apr 10, 2014
…DB Java driver. Upgrade next MongoDB driver version to 2.12.0. Strong upgrade coming in a subsequent commit to make sure we can backport the compatibility checks to the bugfix branch without forcing users into a driver upgrade. Relaxing error message comparison in assertion so that it still matches against the message returned by MongoDB 2.6. When comparing the value of the version field, compare against a Long rather than an Integer, since the version field generated is a Long. This allows the test to pass against the upcoming 2.12.0 release of the Java driver, which has a stricter implementation of BasisDBObject.equals(…). Original pull requests: #159, #160.
odrotbohm
pushed a commit
that referenced
this pull request
Apr 15, 2014
…DB Java driver. Upgrade next MongoDB driver version to 2.12.0. Strong upgrade coming in a subsequent commit to make sure we can backport the compatibility checks to the bugfix branch without forcing users into a driver upgrade. Relaxing error message comparison in assertion so that it still matches against the message returned by MongoDB 2.6. When comparing the value of the version field, compare against a Long rather than an Integer, since the version field generated is a Long. This allows the test to pass against the upcoming 2.12.0 release of the Java driver, which has a stricter implementation of BasisDBObject.equals(…). Original pull requests: #159, #160.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB 2.6 is returning an error message starting with:
"Insert list failed: insertDocument :: caused by :: "
which was making this test fail.
Note also that to test against MongoDB 2.6.0-rc2 I had to in the setup method first strip the "-rc2" from the version before passing it to Spring's Version class, which doesn't handle anything but integer versions.