DATAMONGO-884 - Crash on calling override method of Object class when the class is an DBRef(lazy=true) #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter "method" can be either from Object's method or an override of original Object method.
ReflectionUtils.isObjectMethod(method) only check if the same method exists in Object.
So in order to check if the method is an original method from Object class, it needs to explicitly check method.getDeclaringClass() with Object.class.
For example below,
public class B
{
@id
private String id;
private String value;
@OverRide
public String toString(){
return String.format("B[id='%s', value='%s']",id,value);
}
}
public class A
{
@DBREF(lazy=true)
public B b;
@OverRide
public String toString()
{
return String.format("A[b='%s']",b);
}
}
if class A is loaded with current DefaultDbRefResolver, when class B.toString() is called, it will result NullPointerException since the toString method is not actually from Object.
If we also check "method.getDeclaringClass()==Object.class," it will resolve the issue