DATAMONGO-362 - initial support for Specification #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot Patryk. @timowest - Any chance you have a brief look, whether the additional |
|
Sorry for the late response. I think the abstraction is not necessary. If DbRef based constraints are needed Querydsl queries can be used directly instead. I think it works the same way for Spring Data JPA as well. |
odrotbohm
force-pushed
the
master
branch
2 times, most recently
from
9cbd59a to
d2ecd65
Compare
|
@noter Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for initial review purpose to fix DATAMONGO-362.
Because there is a little different syntax in QueryDSL to query documents based on 'DBRef'. I adapted 'Specification' solution from Spring Data JPA to solve this.
There is currently a limitation in QueryDSL, that can be only conjunction between joins predicates.
Do you think is a good idea or is there a better way? Can we implements something else based on 'Specification' ?