Skip to content

Add possibility to use Collection<Criteria> as parameter in and/or/nor operators [DATAMONGO-2428] #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Nov 27, 2019 · 1 comment
Closed

Add possibility to use Collection<Criteria> as parameter in and/or/nor operators [DATAMONGO-2428] #3286

spring-projects-issues opened this issue Nov 27, 2019 · 1 comment
Assignees
@mp911de @christophstrobl
Labels
in: core Issues in core support type: enhancement A general enhancement
Milestone
3.2 M5 (2021.0.0)

Comments

@spring-projects-issues
Copy link

Ziemowit opened DATAMONGO-2428 and commented

Current state:

For now Criteria class allows to build or/and/nor operators in style:

operator(Criteria... c)

 

Requested change:

Criteria class should allow to build or/and/nor operators also in style (similar as it is possible for in/nin operators):

operator(Collection<Criteria> c)

 

Reference URL: #811
@spring-projects-issues
Copy link
Author

Mark Paluch commented

Thanks for your proposal. We need a bigger revision of the overall and/or/nor operator handling in Criteria. Right now, the API follows MongoDB's restrictions around field names. Instead, it would make sense to naturally specify criteria while the Criteria object produces the correct representation without being required to use andOperator and such. We will leave the pull request open until then

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core support labels Dec 30, 2020
@mp911de mp911de linked a pull request Feb 19, 2021 that will close this issue
DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators #811
Closed
@mp911de mp911de self-assigned this Feb 19, 2021
@mp911de mp911de added this to the 3.2 RC1 (2021.0.0) milestone Feb 19, 2021
mp911de added a commit that referenced this issue Feb 19, 2021
@mp911de
Polishing.
bcb5628 
Update javadoc, add since tags. Add non-null assertions. Introduce overload for type(…) accepting a collection

See #3286.
Original pull request: #811.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

@christophstrobl christophstrobl

Labels
in: core Issues in core support type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M5 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators
3 participants
@mp911de @christophstrobl @spring-projects-issues