Skip to content

Fixed PrimaryTerm/SeqNo datatypes in UpdateQuery #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheHett
Copy link
Contributor

@TheHett TheHett commented Jul 22, 2025

Fixed incorrect datatype of primaryTerm/seqNo fields in UpdateQuery (just changed Int -> Long)

I did not find similar cases in other classes.

Closes #3136

Signed-off-by: Anton Buz <buzdalkin.a@vlprojects.pro>
@TheHett TheHett force-pushed the gh3136-fix-primary-term-datatype branch from 37ccc8e to fa8c714 Compare July 22, 2025 14:30
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2025
@sothawo sothawo merged commit 7f7cf3f into spring-projects:main Jul 22, 2025
1 check passed
@sothawo
Copy link
Collaborator

sothawo commented Jul 22, 2025

Thank you for the PR (and finding that inconsistency).

There are two small additional changes - which I will address in a follow up commit:

  • the code in the RequestConverter where these fields are used can be cleaned up.
  • as this is a breaking API change for users, the documentation needs to be adapted

@TheHett TheHett deleted the gh3136-fix-primary-term-datatype branch July 23, 2025 03:00
@TheHett
Copy link
Contributor Author

TheHett commented Jul 23, 2025

@sothawo Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateQuery primaryTerm/seqNo should be long?
3 participants