Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing attributes to ServletRegistration annotation #45006

Closed
wants to merge 3 commits into from
Closed

Add missing attributes to ServletRegistration annotation #45006

wants to merge 3 commits into from
+204 −0

Conversation

dmytrodanilenkov
Copy link

@dmytrodanilenkov dmytrodanilenkov commented Apr 4, 2025 •
edited
Loading

Closes #45001

@dmytrodanilenkov dmytrodanilenkov changed the title Fix for issue #45000 - add properties initParameters servletRegistrationBeans multipartConfig to @ServletRegistration Fix for issue #45001 - add properties initParameters servletRegistrationBeans multipartConfig to @ServletRegistration Apr 4, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2025
dmytrodanilenkov added 2 commits April 4, 2025 19:16
Fix for issue spring-projects#45000 - ServletRegistrationBean has tho…
fd705c8 
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig

Signed-off-by: dmytrodanilenkov <d.danilenkov.ext@sportradar.com>
Fix for issue spring-projects#45000 - ServletRegistrationBean has tho…
ab74295 
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: dmytrodanilenkov <d.danilenkov.ext@sportradar.com>
@dmytrodanilenkov
Fix for issue spring-projects#45000 - ServletRegistrationBean has tho…
3da51dc 
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@wilkinsona
Copy link
Member

Duplicates #45005.

@wilkinsona wilkinsona closed this Apr 4, 2025
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 4, 2025
@wilkinsona
Copy link
Member

Thanks, @dmytrodanilenkov, but someone else opened a PR for the same change a little before you.

@dmytrodanilenkov
Copy link
Author

@wilkinsona not sure I got it. I opened for #45001, not for #45000

@dmytrodanilenkov dmytrodanilenkov mentioned this pull request Apr 4, 2025
Open
@wilkinsona
Copy link
Member

Oops, sorry about that. I was confused by the references to #45000 in the commit messages.

@mhalbritter mhalbritter changed the title Fix for issue #45001 - add properties initParameters servletRegistrationBeans multipartConfig to @ServletRegistration Add missing attributes to ServletRegistration annotation Apr 7, 2025
mhalbritter
mhalbritter reviewed Apr 7, 2025
View reviewed changes
...ject/spring-boot/src/main/java/org/springframework/boot/web/servlet/ServletRegistration.java
@Target({})
@Retention(RetentionPolicy.RUNTIME)
@Documented
@interface MultipartConfigValues {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we directly use jakarta.servlet.annotation.MultipartConfig here?

@mhalbritter
Copy link
Contributor

I like the handling of initParameters and servletRegistrationBeans in #45005. Could you rework your PR to match #45005?

@mhalbritter mhalbritter added status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged status: duplicate A duplicate of another issue and removed status: duplicate A duplicate of another issue status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Apr 7, 2025
@mhalbritter
Copy link
Contributor

Dupe of #45007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhalbritter mhalbritter mhalbritter left review comments

Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing attributes to ServletRegistration annotation
4 participants
@dmytrodanilenkov @wilkinsona @mhalbritter @spring-projects-issues