Introduce spring.data.mongodb.protocol to allow the MongoDB protocol to be customized when not using spring.data.mongodb.uri #44366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
force-pushed
the
43851
branch
5 times, most recently
from
a51cf6c to
0c4e77d
Compare
This commit allows configuring the MongoDB connection protocol using the 'spring.data.mongodb.protocol' property. See spring-projectsgh-43851 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
snicoll
reviewed
Feb 22, 2025
| @@ -51,6 +51,11 @@ public class MongoProperties { | |||
| */ | |||
| public static final String DEFAULT_URI = "mongodb://localhost/test"; | |||
|
|
|||
| /** | |||
| * Protocol to be used for the MongoDB connection. Ignored if 'uri' is set. | |||
There was a problem hiding this comment.
I was just looking at this and laughed that it matches the polish I've made in 44384. What a coincidence! Nope, you forced push to adapt... You really didn't have to do it, thanks!
There was a problem hiding this comment.
I noticed that you've merged #44384 and checked what phrasing was used to update this change accordingly.
mhalbritter
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
Feb 25, 2025
This commit allows configuring the MongoDB connection protocol using the 'spring.data.mongodb.protocol' property. See gh-44366 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
mhalbritter
changed the title
|
Thanks @nosan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gh-43851