Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested test classes don't inherit properties from @DataJpaTest on enclosing class #44348

Conversation

bernie-schelberg-invicara
Copy link
Contributor

The commit 5669ea6
omitted the DataJpaTestContextBootstrapper. This PR applies similar changes to the other commit.

Fixes gh-33317

Fixes spring-projectsgh-33317

Signed-off-by: Bernie Schelberg <bernard.schelberg@invicara.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2025
@bclozel
Copy link
Member

bclozel commented Feb 19, 2025

@bernie-schelberg-invicara Spring Boot 2.7.x is not OSS supported anymore so we can merge contributions in the 3.3.x branch at the earliest.

@bernie-schelberg-invicara bernie-schelberg-invicara changed the base branch from 2.7.x to 3.3.x February 19, 2025 07:02
@bernie-schelberg-invicara
Copy link
Contributor Author

@bclozel thanks, I've updated the target branch

@wilkinsona wilkinsona changed the title Consider properties on outer class in nested @DataJpaTest tests Nested test classes don't inherit properties from @DataJpaTest on enclosing class Feb 19, 2025
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 19, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Feb 19, 2025
@snicoll snicoll self-assigned this Feb 22, 2025
@snicoll snicoll modified the milestones: 3.3.x, 3.3.10 Feb 22, 2025
snicoll pushed a commit that referenced this pull request Feb 22, 2025
See gh-44348

Signed-off-by: Bernie Schelberg <bernard.schelberg@invicara.com>
snicoll added a commit that referenced this pull request Feb 22, 2025
@snicoll snicoll closed this in b711489 Feb 22, 2025
@snicoll
Copy link
Member

snicoll commented Feb 22, 2025

@bernie-schelberg-invicara thank you, and congrats for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants