Logback configuration that relies on inner-classes does not work in a native image #44021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
force-pushed
the
44016
branch
2 times, most recently
from
2518f9f to
9935ac3
Compare
Before this commit, the generated name for the inner class had the wrong format <package>.<parent>.<child> (canonical name). GraalVM expects $ to separate the parent from the inner class. This commit updates SpringBootJoranConfigurator to generate an appropriate format for a class name. Specifically, an inner class should be separated by a dollar sign, not a dot. See spring-projectsgh-44016 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
wilkinsona
changed the title
wilkinsona
added
type: bug
|
Oh, I apologize for the mistake. The target branch should be 3.3.x. :( |
|
No problem at all! You've done more than enough already. I'll take care of it as part of merging the fix. |
wilkinsona
pushed a commit
that referenced
this pull request
Jan 30, 2025
Before this commit, the generated name for the inner class had the wrong format <package>.<parent>.<child> (canonical name). GraalVM expects $ to separate the parent from the inner class. This commit updates SpringBootJoranConfigurator to generate an appropriate format for a class name. Specifically, an inner class should be separated by a dollar sign, not a dot. See gh-44021 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
wilkinsona
added a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the generated name for the inner class had the wrong format
<package>.<parent>.<child>(canonical name). GraalVM expects $ to separate the parent from the inner class.This commit updates
SpringBootJoranConfiguratorto generate an appropriate format for a class name. Specifically, an inner class should be separated by a dollar sign, not a dot.See gh-44016