Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isXxx() instead of getXxx() for boolean property #43934

Closed
wants to merge 1 commit into from
Closed

Use isXxx() instead of getXxx() for boolean property #43934

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jan 23, 2025

No description provided.

@quaff
Use isXxx() instead of getXxx() for boolean property
ed4a38a 
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 23, 2025
@philwebb philwebb self-assigned this Jan 24, 2025
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 24, 2025
@philwebb philwebb added this to the 3.5.x milestone Jan 24, 2025
philwebb pushed a commit that referenced this pull request Jan 24, 2025
@quaff @philwebb
Use isXxx() instead of getXxx() for boolean properties
964abef 
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>

See gh-43934
philwebb added a commit that referenced this pull request Jan 24, 2025
@philwebb
Polish 'Use isXxx() instead of getXxx() for boolean properties'
5850306 
See gh-43934
@philwebb philwebb closed this in f8ae1ff Jan 24, 2025
@philwebb
Copy link
Member

Thanks @quaff, I've dropped the @Deprecated method in the hope that we can get away with the change since configuration properties aren't considered public API.

@philwebb philwebb modified the milestones: 3.5.x, 3.5.0-M2 Jan 24, 2025
arefbehboudi pushed a commit to arefbehboudi/spring-boot that referenced this pull request Jan 29, 2025
@quaff @arefbehboudi
Use isXxx() instead of getXxx() for boolean properties
fdb1e0b 
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>

See spring-projectsgh-43934

Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
arefbehboudi pushed a commit to arefbehboudi/spring-boot that referenced this pull request Jan 29, 2025
@philwebb @arefbehboudi
Polish 'Use isXxx() instead of getXxx() for boolean properties'
4aad11e 
See spring-projectsgh-43934

Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @philwebb @spring-projects-issues